Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Maker offer configuration #3

Closed
Tracked by #75
da-kami opened this issue Aug 31, 2021 · 6 comments
Closed
Tracked by #75

Maker offer configuration #3

da-kami opened this issue Aug 31, 2021 · 6 comments

Comments

@da-kami
Copy link
Contributor

da-kami commented Aug 31, 2021

Instead of a static offer the maker has UI fields to create an offer.

@bonomat
Copy link
Collaborator

bonomat commented Sep 21, 2021

What do you think of having dynamically priced offers?

The user enters a spread instead of a fixed rate for the offer (in addition to other parameters as amounts and leverage). The actual rate is then computed dynamically and periodically using some price feed (e.g. bitmex).
Whenever the price changes, the maker tells its connected peers that the price has changed.

@thomaseizinger
Copy link
Contributor

What do you think of having dynamically priced offers?

The user enters a spread instead of a fixed rate for the offer (in addition to other parameters as amounts and leverage). The actual rate is then computed dynamically and periodically using some price feed (e.g. bitmex).
Whenever the price changes, the maker tells its connected peers that the price has changed.

If I remember correctly, our initial scope was to manually create an offer when we know that someone wants to try out the product with us.

It is a good idea but sounds out of scope from what we have discussed.

@bonomat
Copy link
Collaborator

bonomat commented Sep 21, 2021

Do you think this would change the scope too much?

If so, we could do the same thing without auto update. The interesting part here is that the user (the maker) does not have to do the math to come up with a price but it gets computed automatically.

@thomaseizinger
Copy link
Contributor

If we want to keep our existing architecture of dumb frontend with all calculations in the backend then yes it is quite a bit of a change because either

a) you send and store the user's parameters (spread, etc) in the backend so you can compute the price and send it out on the feed / to the takers
b) you provide a calculation endpoint that is hit every time you change any of the inputs

I don't think any of the above are worth doing if all we get out of it is not having the user do some math. We can easily implement this as a feature on top once everything else works.

@thomaseizinger
Copy link
Contributor

At the very least, we need the manual thing working first.

I think this actually already implemented anyway and just this ticket is stale.

@da-kami please confirm and close if so.

@da-kami
Copy link
Contributor Author

da-kami commented Sep 22, 2021

I propose #108

What is described by @bonomat is out of scope for this ticket (will close this ticket).
Please refer to #108 - I think this can be in scope for the MVP. I see automated offer re-publication as out of scope for the MVP.

@da-kami da-kami closed this as completed Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants