Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial value of the input field #2

Closed
bluec opened this issue Jun 27, 2022 · 2 comments · May be fixed by #3
Closed

Set initial value of the input field #2

bluec opened this issue Jun 27, 2022 · 2 comments · May be fixed by #3

Comments

@bluec
Copy link

bluec commented Jun 27, 2022

For use-cases where the postcode lookup might be using existing data (e.g. editing an address rather than adding as new) it would be useful to have the ability to set the initial value of the input field.

@LeePaulSmith
Copy link
Contributor

LeePaulSmith commented Jul 26, 2022

Hi,

Sorry, this would be a confusing design. In the situation provided, the address data should be cleared and a new search initiated.
Also, it would be unlikely the new address would be in the same postcode.

Regards

@bluec
Copy link
Author

bluec commented Jul 26, 2022

Sorry, how do you know what should happen in this situation? The library should provide flexibility for integrators to integrate it into their own workflows. Those workflows are not for you to dictate. I can 100% tell you that being able to lookup from an existing postcode is a completely valid and required real-life workflow.

Furthermore, the proposed change still allows for no initial value to be set (i.e. by default it doesn't change existing behaviour), so I can't really see any rationale for it to be rejected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants