Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update swc core to latest version #1190

Closed
wants to merge 1 commit into from

Conversation

escapedcat
Copy link
Contributor

@escapedcat escapedcat commented Jul 24, 2022

One test is failing with:

 FAIL  src/app/components/AccountMenu/index.test.tsx
  ● Test suite failed to run

    TypeError: Cannot redefine property: useAccounts
        at Function.defineProperty (<anonymous>)

      19 | };
      20 |
    > 21 | jest.spyOn(AccountsContext, "useAccounts").mockReturnValue({
         |      ^
      22 |   accounts: mockAccounts,
      23 |   getAccounts: jest.fn(),
      24 | });

v1.2.206 correct something which is breaking wrong usage of imports. Need to check what needs to be changed here:
See:

Suggested workaround npm-module solves this issue but new ones pop up:

 FAIL  src/extension/background-script/actions/allowances/__tests__/list.test.ts
  ● Test suite failed to run

    TypeError: Object.defineProperty called on non-object
        at defineProperty (<anonymous>)

      10 |
      11 |   constructor() {
    > 12 |     super("LBE");
         |                                                ^
      13 |     this.version(1).stores({

@socket-security
Copy link

socket-security bot commented Jul 24, 2022

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
@swc/core@1.2.218 (upgraded) postinstall package.json
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules

Powered by socket.dev

@github-actions
Copy link

Build files:

@escapedcat escapedcat added dependencies Pull requests that update a dependency file bug Something isn't working labels Jul 24, 2022
@escapedcat
Copy link
Contributor Author

Closing this in favour of #1218

@escapedcat escapedcat closed this Aug 15, 2022
@escapedcat escapedcat deleted the chore/deps-swc-206 branch November 14, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant