Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/deps swc 220 plus workaround #1218

Merged
merged 8 commits into from
Nov 28, 2022

Conversation

escapedcat
Copy link
Contributor

@escapedcat escapedcat commented Jul 30, 2022

Latest swc updates break our Jest setup. There's is a workaround but we still need to adjust our setup.
Staying on v205 is currently working for us.

SWR and Jest

See this discussion for SWR with Jest
=> swc-project/swc#5151 (comment)

@github-actions
Copy link

Build files:

@socket-security
Copy link

socket-security bot commented Jul 30, 2022

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
@swc/core@1.3.20 (upgraded) postinstall package.json
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore @swc/core@1.3.20

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@escapedcat escapedcat force-pushed the chore/deps-swc-220-plus-workaround branch from 362336e to d36633c Compare July 30, 2022 07:30
@escapedcat escapedcat added the dependencies Pull requests that update a dependency file label Jul 31, 2022
@bumi
Copy link
Collaborator

bumi commented Aug 15, 2022

what is this one about?

@escapedcat
Copy link
Contributor Author

what is this one about?

Adjusted the description

@bumi
Copy link
Collaborator

bumi commented Oct 16, 2022

is this still active or can we close it?

@escapedcat
Copy link
Contributor Author

escapedcat commented Oct 17, 2022

is this still active or can we close it?

We should solve this

@bumi
Copy link
Collaborator

bumi commented Oct 26, 2022

so then let's solve this. July is already very old.

@escapedcat
Copy link
Contributor Author

It's about priorities. Happy to touch this after the manifest.

@escapedcat escapedcat force-pushed the chore/deps-swc-220-plus-workaround branch 2 times, most recently from 8a45935 to 89da2d2 Compare November 18, 2022 13:14
@escapedcat escapedcat marked this pull request as ready for review November 18, 2022 13:16
@escapedcat escapedcat marked this pull request as draft November 18, 2022 13:20
@github-actions
Copy link

github-actions bot commented Nov 18, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

@escapedcat escapedcat marked this pull request as ready for review November 18, 2022 14:26
@escapedcat escapedcat force-pushed the chore/deps-swc-220-plus-workaround branch from 8cb1303 to 466315e Compare November 23, 2022 16:30
Copy link
Contributor

@lisabaut lisabaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added the link to the swr discussion to the description for later documentation.

I think, your current fix with removing spyOn is ok for now.

@escapedcat
Copy link
Contributor Author

Thanks, I added the link to the swr discussion to the description for later documentation.

I think, your current fix with removing spyOn is ok for now.

Thanks, already watching that discussion.

@escapedcat escapedcat force-pushed the chore/deps-swc-220-plus-workaround branch from 13e7867 to e2cb931 Compare November 28, 2022 15:36
@escapedcat escapedcat merged commit 561f728 into master Nov 28, 2022
@escapedcat escapedcat deleted the chore/deps-swc-220-plus-workaround branch November 28, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants