fix: added error message for change password

[ShivamJhaa]

Describe the changes you have made in this PR

Added error message when we try to update the password and alby account is locked.

Link this PR to an issue [optional]

Fixes _#1632

Type of change

(Remove other not matching type)

• fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

alby.mp4

Add screenshots to make your changes easier to understand. You can also add a video here.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

• My code follows the style guidelines of this project and performed a self-review of my own code
• New and existing tests pass locally with my changes
• I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

[ShivamJhaa]

@im-adithya Can you please review this PR and start the CI test for the PR?
Thanks!

[rolznz]

Is it possible when logging out to make the entire extension tab inaccessible? it seems strange to log out and still have access to the settings page.

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: channel.ninja (who recently dropped 1000 sats):

---

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

[im-adithya]

Thanks for the PR @ShivamJhaa!

However, as @rolznz suggested, this page shouldn't appear whenever the user locks the extension. So instead of showing an error toast, can you modify the code to close all the extension tabs on lock?

Here's the lock function: https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/background-script/state.ts#L119

You can fetch all the currently open extension tabs and close them there. See https://developer.chrome.com/docs/extensions/reference/extension/#method-getViews

Again, thanks for letting us know about the issue; let me know if you need help!

[bumi]

thanks for the PR!

[bumi]

@im-adithya @ShivamJhaa I'd do both. catching a potential error and showing an error message is still a good idea I think. maybe something else goes wrong, so at least the user knows.

[ShivamJhaa]

Thanks for the PR @ShivamJhaa!

However, as @rolznz suggested, this page shouldn't appear whenever the user locks the extension. So instead of showing an error toast, can you modify the code to close all the extension tabs on lock?

Here's the lock function: https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/background-script/state.ts#L119

You can fetch all the currently open extension tabs and close them there. See https://developer.chrome.com/docs/extensions/reference/extension/#method-getViews

Again, thanks for letting us know about the issue; let me know if you need help!

Thanks for the help, I have made the changes as suggested. Please take a look.

alby2.mp4

[escapedcat]

ack

[ShivamJhaa]

@im-adithya Please take a look, I have resolved the merge conflicts and need some help over this comments #2025 (comment)
Thanks!

[ShivamJhaa]

@im-adithya Done the changes as suggested.