Merge pull request #251 from getAlby/fix/consistent-http-status-keysend

respond with 500 if no payment sent
getAlby · Dec 23, 2022 · 0564bc0 · 0564bc0
2 parents 5e78990 + 3bcd458
commit 0564bc0
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/controllers_v2/keysend.ctrl.go b/controllers_v2/keysend.ctrl.go
@@ -109,6 +109,7 @@ func (controller *KeySendController) MultiKeySend(c echo.Context) error {
 	result := &MultiKeySendResponseBody{
 		Keysends: []KeySendResult{},
 	}
+	singleSuccesfulPayment := false
 	for _, keysend := range reqBody.Keysends {
 		keysend := keysend
 		res, err := controller.SingleKeySend(c, &keysend, userID)
@@ -125,8 +126,13 @@ func (controller *KeySendController) MultiKeySend(c echo.Context) error {
 		result.Keysends = append(result.Keysends, KeySendResult{
 			Keysend: res,
 		})
+		singleSuccesfulPayment = true
 	}
-	return c.JSON(http.StatusOK, result)
+	status := http.StatusOK
+	if !singleSuccesfulPayment {
+		status = http.StatusInternalServerError
+	}
+	return c.JSON(status, result)
 }
 
 func (controller *KeySendController) SingleKeySend(c echo.Context, reqBody *KeySendRequestBody, userID int64) (result *KeySendResponseBody, resp *responses.ErrorResponse) {