respond with 500 if no payment sent #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Dec 23, 2022
| return c.JSON(http.StatusOK, result) | ||
| status := http.StatusOK | ||
| if !singleSuccesfulPayment { | ||
| status = http.StatusInternalServerError |
There was a problem hiding this comment.
is this a correct HTTP status code?
internal server error indicates it's an exception an unexpected bug in our system
payments might fail because the recipient can not receive anything.
maybe a 422 - Unprocessable Entity?
There was a problem hiding this comment.
That would deserve it's own PR as we would need to change it everywhere we're making a payment. I'd rather have it consistent for now.
There was a problem hiding this comment.
we return a 500 if a payment fails? damn, also not a good http cititzen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250