Feature/graceful shutdown #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiidb
commented
Jan 17, 2023
| @@ -243,11 +243,6 @@ func (svc *LndhubService) InvoiceUpdateSubscription(ctx context.Context) error { | |||
| if err != nil { | |||
| svc.Logger.Errorf("Error processing invoice update subscription: %v", err) | |||
| sentry.CaptureException(err) | |||
| // TODO: close the stream somehoe before retrying? | |||
There was a problem hiding this comment.
I needed to remove this because the "error" that is returned here, if there is one, is most likely the context cancellation. Even if it is some kind of other error, I feel it doesn't really make sense to add these kind of ad-hoc reconnects here.
LucasRouckhout
approved these changes
Feb 4, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285
Based on this article.
We need to shutdown a maximum of 3 servers:
These servers are shut down gracefully by calling some kind of
StoporShutdownfunction frommain.goafterbackgroundCtxis canceled, which is done when the signal receives anos.Interupt(Ctrl-c) signal.Other than that there are the background routines:
These are also canceled by canceling the
backgroundCtxcontext. The waitgroup waits until all processes are finished before the program is exited.