Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311
The issue was that the "delete invoice" call didn't work and this was not noticed because the error wasn't logged.
We reproduced this but the real fix is to postpone the invoice db entry creation until after preliminary checks have taken place (amount, user balance, invoice expiry (todo #315 )).
In order to do this, this PR does the following things:
BalanceCheck
code to the service packageCalcFeeLimit
code from the invoice struct to the service structAddOutgoingInvoice
call in all 4 payment controllers behind theBalanceCheck
block, which should look the same everywhere.