Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrating payment failed errors to json logging #475

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

reneaaron
Copy link
Contributor

No description provided.

@reneaaron reneaaron marked this pull request as ready for review December 30, 2023 11:36
@reneaaron reneaaron requested a review from bumi December 30, 2023 11:36
@bumi bumi requested a review from im-adithya January 3, 2024 10:57
log.JSON{
"message": "payment failed",
"error": err,
"lndhub_user_id": userID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the app here we use user_id so far.
should we move to specifying it as lndhub_user_id or is the app + user_id combination enough?

@bumi bumi merged commit a6f493e into main Jan 8, 2024
3 checks passed
@bumi bumi deleted the feat/json-logging branch January 8, 2024 22:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants