Skip to content
This repository has been archived by the owner on Mar 5, 2020. It is now read-only.

Fix broken JS tests on Ember 2.11 #83

Closed
getaclue00 opened this issue Jan 29, 2017 · 4 comments
Closed

Fix broken JS tests on Ember 2.11 #83

getaclue00 opened this issue Jan 29, 2017 · 4 comments
Assignees

Comments

@getaclue00
Copy link
Owner

getaclue00 commented Jan 29, 2017

as a result of #81, we have the following files that are currently broken:

  • tests/integration/components/service-editor-test.js
  • tests/unit/controllers/employees/delete-test.js
  • tests/unit/controllers/employees/new-test.js
  • tests/unit/controllers/my-calendar/appointments/show-test.js
  • tests/unit/controllers/services/delete-test.js
  • tests/unit/controllers/services/new-test.js
  • tests/unit/controllers/services/show-test.js

From what I can see, the majority of the problems is due to testing of async functions; Usually, the following error occurs:

Assertion after the final `assert.async` was resolved

However there are some other minute details as well. Each person who worked on one of these would probably be best to fix the broken tests.

@Leann88
Copy link
Collaborator

Leann88 commented Jan 29, 2017

Should we make a branch off #81 to fix these tests?

@getaclue00
Copy link
Owner Author

@Leann88 ughm, if you want... just make sure to be up to date on that branch. But I am pretty close for it being ready to merge.

@Leann88
Copy link
Collaborator

Leann88 commented Feb 3, 2017

I think this is part of #91

@Leann88
Copy link
Collaborator

Leann88 commented Feb 23, 2017

closing, fixed in #96

@Leann88 Leann88 closed this as completed Feb 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants