Skip to content
This repository has been archived by the owner on Apr 25, 2019. It is now read-only.

Can Toggles be More User Friendly? #66

Closed
daveredfern opened this issue Aug 19, 2016 · 8 comments
Closed

Can Toggles be More User Friendly? #66

daveredfern opened this issue Aug 19, 2016 · 8 comments
Assignees
Milestone

Comments

@daveredfern
Copy link
Member

We're really struggling to use toggles. They're just not working for us. The main problem is we're unable to activate and deactivate things at the same time. It makes any slight customisation impossible with toggles.

I propose we remove data-cc-action and replace it with:

data-cc-activate
data-cc-deactivate
data-cc-toggle

Then we can pass ID through to these data attributes.

Cascading is still handy and could (hopefully) work as originally implemented.

The benefit of this is we can then activate and deactivate items as we wish.

Thoughts @gazjoy @balloz ?

@gazjoy
Copy link
Collaborator

gazjoy commented Aug 19, 2016

@daveredfern agreed, either we change or write some clear documentation and code demos. We are desperate for documentation on this.

@daveredfern
Copy link
Member Author

@gazjoy @balloz I think it needs changes to simplify it. If that means it is less flexible, I am happy with that. I am finding it harder to implement toggles than it is to write custom JS. The custom JS is often only a few lines long too.

Maybe a meeting required to take the last few sites using chopchop and screenshot all the usecases for toggles.

@gazjoy gazjoy changed the title Toggles are a pain to work with Can Toggles be More User Friendly? Oct 13, 2016
@gazjoy
Copy link
Collaborator

gazjoy commented Oct 17, 2016

@daveredfern worth a read. Lots of accessibility that we currently dont have and no dependency in jQuery.

http://hugogiraudel.com/2016/10/13/you-might-need-javascript/
https://github.com/edenspiekermann/a11y-dialog
https://github.com/edenspiekermann/a11y-toggle

@gazjoy
Copy link
Collaborator

gazjoy commented Nov 3, 2016

@daveredfern found this little gem: https://bitsofco.de/the-target-trick/ Support is solid: http://caniuse.com/#search=%3Atarget

@daveredfern
Copy link
Member Author

@gazjoy what are we doing with this? Don't want this to just sit here for months.

@gazjoy gazjoy modified the milestone: November 2016 Nov 24, 2016
@gazjoy gazjoy assigned llapgoch and unassigned daveredfern, gazjoy and balloz Nov 24, 2016
@gazjoy gazjoy added this to the December 2016 milestone Nov 24, 2016
@gazjoy
Copy link
Collaborator

gazjoy commented Dec 12, 2016

@llapgoch is currently re writing the js toggles using a jQuery widgetised approach.

@gazjoy
Copy link
Collaborator

gazjoy commented Dec 20, 2016

@llapgoch Does adding aria landmarks affect you? https://24ways.org/2015/how-tabs-should-work/

@gazjoy
Copy link
Collaborator

gazjoy commented Jan 30, 2017

This is now in: bf1a354

@gazjoy gazjoy closed this as completed Jan 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants