Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable test plan checking #112

Closed
cjol opened this issue Jul 14, 2022 · 5 comments
Closed

Can't disable test plan checking #112

cjol opened this issue Jul 14, 2022 · 5 comments

Comments

@cjol
Copy link

cjol commented Jul 14, 2022

I'm just giving spr a try, and don't want to use test plans in my commit messages. I've tried to change the configuration settings but it seems to be blocking my commit anyway:

❯ spr --version
spr 1.3.3

❯ tail .git/config 
[spr]
        githubAuthToken = .....
        githubRemoteName = origin
        githubRepository = powerxai/application-v3
        githubMasterBranch = main
        branchPrefix = spr/cjols/
        requireTestPlan = false
        requireApproval = true

❯ git config --get spr.requireTestPlan  
false

❯ spr diff --all                        
3f5c1c5 fix(alarms): Use all dimensions for Cloudwatch queue metrics
  💔  Commit message does not have a Test Plan!

Am I missing something?

@sven-of-cord
Copy link
Contributor

sven-of-cord commented Jul 14, 2022

The requireTestPlan setting was added after the last release. It will become available with the next release.

[EDIT: I made a copy-paste mistake and this comment originally said requireApproval]

@cjol
Copy link
Author

cjol commented Jul 14, 2022

I assume you mean the requireTestPlan setting?

@sven-of-cord
Copy link
Contributor

sven-of-cord commented Jul 14, 2022

I assume you mean the requireTestPlan setting?

Oops, sorry, yes of course! (I edited my comment above for future readers)

@alper
Copy link

alper commented Aug 17, 2022

What is this test plan thing anyway (is it documented somewhere?) and what does it have to do with this way of working? Can it be made entirely optional?

@rockwotj
Copy link
Contributor

It's documented here: https://getcord.github.io/spr/reference/configuration.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants