Allow spr format to be used without GitHub credentials
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4-beta.1
jozef-mokry
approved these changes
Jul 18, 2022
flooey
approved these changes
Jul 18, 2022
Oh wow, yes, true. Hadn't thought of that. Ah well, might as well land this now. |
Created using spr 1.3.4-beta.1
sven-of-cord
deleted the
spr/sven-of-cord/allow-spr-format-to-be-used-without-github-credentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format command does not use the GitHub API, it only reformats the local commit message.
This commit makes it so that
spr formatcan be called without a GitHub PAT in the config.This is particularly useful to have a slightly more meaningful automated test of the spr build. For example homebrew allows to define tests of the binary as part of the packaging recipe. With this change, we can test using
spr format, which at least tests that a Git repository is opened correctly.Test Plan:
use
spr formatand see that it correctly reformats a messy commit message