Simplify fetching eligible reviewers in spr diff #123
Merged
+35
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5-beta.1
flooey
approved these changes
Jul 21, 2022
sven-of-cord
deleted the
spr/sven-of-cord/simplify-fetching-eligible-reviewers-in-spr-diff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is extra code in the diff command to start fetching eligible reviewers from GitHub ahead of time, but it has become pointless. There is no other
awaitbetween the place where we callgh.get_reviewers()and where we await the returned future. Also, we don't spawn a task with the returned future, so work only begins when we finally await. This is all very much pointless, so this commit just moves callinggh.get_reviewers()to where we need it and await it.Test Plan:
Run
spr diffto submit this diff, with reviewers listed in the local commit message, so that spr adds them to the PR.