[easy] Disable terminal text wrapping if message contains URL #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-of-cord
reviewed
Sep 6, 2022
spr/src/output.rs
Outdated
Comment on lines
21
to
25
| if lazy_regex::regex_is_match!(r#"https?://"#, text) { | ||
| options.break_words = false; | ||
| options.word_separator = textwrap::WordSeparator::AsciiSpace; | ||
| options.word_splitter = textwrap::WordSplitter::NoHyphenation; | ||
| } |
There was a problem hiding this comment.
These options look reasonable. I'd be okay with using them unconditionally.
Suggested change
| if lazy_regex::regex_is_match!(r#"https?://"#, text) { | |
| options.break_words = false; | |
| options.word_separator = textwrap::WordSeparator::AsciiSpace; | |
| options.word_splitter = textwrap::WordSplitter::NoHyphenation; | |
| } | |
| options.break_words = false; | |
| options.word_separator = textwrap::WordSeparator::AsciiSpace; | |
| options.word_splitter = textwrap::WordSplitter::NoHyphenation; |
There was a problem hiding this comment.
sounds good! just updated the diff
sven-of-cord
approved these changes
Sep 7, 2022
clarityflowers
pushed a commit
to clarityflowers/spr
that referenced
this pull request
Mar 19, 2024
### Summary Minor issue: by default `textwrap` can break a URL into multiple lines. This makes PR links unclickable when the terminal window is small. I played with a few config options on https://mgeisler.github.io/textwrap/ — think this is the best combo? <img width="600" alt="image" src="https://user-images.githubusercontent.com/2268452/186331956-5b183ff6-6b3f-4ac3-82e8-72d2044abda8.png"> ### Test Plan | Before | After | | ------------- | ------------- | | <img width="491" alt="Screen Shot 2022-08-23 at 9 44 16 PM" src="https://user-images.githubusercontent.com/2268452/186331402-0943f667-6a9f-4c2f-8961-b12997c12b6b.png"> | <img width="491" alt="Screen Shot 2022-08-23 at 9 45 12 PM" src="https://user-images.githubusercontent.com/2268452/186331444-984aeecb-30df-4f59-b84b-0a7735d80bfb.png"> | Pull Request: spacedentist#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor issue: by default
textwrapcan break a URL into multiple lines. This makes PR links unclickable when the terminal window is small.I played with a few config options on https://mgeisler.github.io/textwrap/ — think this is the best combo?
Test Plan