Don't fetch all users/teams to check reviewers #159
Merged
+36
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, reviewers were validated by first fetching all teams
and users, and then checking membership in that result. This suffers
from a few issues:
- it was broken since it seemed to only fetch one page, not all pages
- it is inefficient
- fetching the full list is not necessary
- there was a 1+n style query, where each user returned would then
have their name fetched one by one
This PR modifies reviewer validation by fetching only the users/teams
specified in the commit.
andrewhamon
changed the title
clarityflowers
pushed a commit
to clarityflowers/spr
that referenced
this pull request
Mar 19, 2024
Prior to this PR, reviewers were validated by first fetching all teams and users, and then checking membership in that result. This suffers from a few issues: - it was broken since it seemed to only fetch one page, not all pages. This can't work with any significant number of users or teams in an organization. - it is inefficient - fetching the full list is not necessary - there was a 1+n style query, where the users name would be looked for each user in the list. This PR modifies reviewer validation by fetching only the users/teams specified in the commit. Reviewers: spacedentist Reviewed By: spacedentist Pull Request: spacedentist#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, reviewers were validated by first fetching all teams and users, and then checking membership in that result. This suffers from a few issues:
This PR modifies reviewer validation by fetching only the users/teams specified in the commit.