Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Continue mysql ingestion #2322

Merged
merged 11 commits into from
Jan 17, 2024
Merged

feat: Continue mysql ingestion #2322

merged 11 commits into from
Jan 17, 2024

Conversation

karolisg
Copy link
Contributor

Closes #2280

@karolisg karolisg requested a review from abcpro1 January 16, 2024 13:32
abcpro1
abcpro1 reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@abcpro1 abcpro1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make CDC resumable. Snapshotting reusability can be done in the future.
I have left some comments, some are functional and others are refactorings. Once the functional issues are resolved, we can merge this.

dozer-ingestion/mysql/src/binlog.rs Outdated Show resolved Hide resolved
dozer-ingestion/mysql/src/binlog.rs Outdated Show resolved Hide resolved
dozer-ingestion/mysql/src/binlog.rs Outdated Show resolved Hide resolved
dozer-ingestion/mysql/src/connector.rs Show resolved Hide resolved
@karolisg karolisg requested a review from abcpro1 January 17, 2024 09:18
@karolisg karolisg added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 11cd9e9 Jan 17, 2024
6 checks passed
@karolisg karolisg deleted the feat/continue-mysql-ingestion branch January 17, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcpro1 abcpro1 abcpro1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL resuming
2 participants
@karolisg @abcpro1