Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAL: postgres connections not being closed #205

Closed
mmiller1 opened this issue Feb 28, 2022 · 4 comments · Fixed by #208
Closed

DAL: postgres connections not being closed #205

mmiller1 opened this issue Feb 28, 2022 · 4 comments · Fixed by #208
Assignees
Labels
bug Something isn't working

Comments

@mmiller1
Copy link
Contributor

noticed something interesting after building the code in the main branch: on every message sent in a channel that gort is in, a dangling connection is left open in postgres, eventually leading to the max_connections parameter being reached, which consequently causes gort to respond to every message in the channel with an error.

I think there are potentially two issues here:
the connections being left open is obviously one, and potentially the second being that we might not want gort automatically responding to DAL related errors in the chat service, this is quite noisy and a real nuisance to people not familiar with the bot itself.

@clockworksoul clockworksoul self-assigned this Mar 6, 2022
@clockworksoul
Copy link
Member

I've identified the issue. A patch will be released today.

@clockworksoul
Copy link
Member

I've identified the issue. A patch will be released today.

It's taking longer than I hoped. The fix can be expected this weekend.

@clockworksoul clockworksoul added the bug Something isn't working label Mar 12, 2022
@clockworksoul clockworksoul linked a pull request Mar 12, 2022 that will close this issue
@clockworksoul
Copy link
Member

a dangling connection is left open in postgres, eventually leading to the max_connections parameter being reached, which consequently causes gort to respond to every message in the channel with an error.

I'm considering this to be the primary issue in this ticket. It's fixed by #208.

we might not want gort automatically responding to DAL related errors in the chat service

This is also true! Let's open a separate issue for this one

@clockworksoul
Copy link
Member

#208 is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants