Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accented characters in URI does not work #1437

Closed
molnarelodbalazs opened this issue Apr 19, 2017 · 11 comments
Closed

Accented characters in URI does not work #1437

molnarelodbalazs opened this issue Apr 19, 2017 · 11 comments

Comments

@molnarelodbalazs
Copy link

Hello there!

I have an URL: http://domain.com/search/query:függvény
The grav config gives me the variable with wrong encoding. :-(
https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Uri.php#L448

What can I do?

@OleVik
Copy link
Contributor

OleVik commented Apr 20, 2017

What is the specific error thrown by Uri.php?

@flaviocopes
Copy link
Contributor

You should see this

schermata 2017-04-20 alle 16 49 58

what do you see, instead?

@molnarelodbalazs
Copy link
Author

I see: f�ggv�ny as in this variable: $config = Grav::instance()['config'];

my header encoding is set to utf-8

@rhukster
Copy link
Member

Seems to work for me also:

2017-04-20 at 4 35 pm

@flaviocopes
Copy link
Contributor

What is the page encoding, sent to the browser? (type document.characterSet in the browser developer tools console)

@molnarelodbalazs
Copy link
Author

Hello!

document.characterSet "UTF-8"

image

I can't find it out what is the problem. The reason why i wrote it here is I investigated my parameter 'till this line.

Thanks for your help!
Előd

@flaviocopes
Copy link
Contributor

Strange then, the charset is correct. Is this happening with Chrome only, or also on other browsers as well?

@flaviocopes
Copy link
Contributor

Can you also try on a separate device, a phone maybe?

@molnarelodbalazs
Copy link
Author

It "works" like this in different browsers.
Here's what i get on browserstack
image

@flaviocopes
Copy link
Contributor

Can you PM me your user/ folder on Slack, so I can try replicating the problem with your same site setup?

@flaviocopes
Copy link
Contributor

I can't replicate.

screen shot 2017-04-27 at 18 20 13

If you make the subdomain public I can try replicating with my browser (it's not accessible at this moment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants