Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to change anyhow to thiserror (or custom error) in grit-pattern-matcher #409

Closed
ematipico opened this issue Jul 9, 2024 · 1 comment · Fixed by #457
Closed

Comments

@ematipico
Copy link

Mostly because anyhow is meant for application code, and this forces downstream dependencies (Biome for example) to use anyhow to import the types and correctly handle the errors.

I wonder if you're open to changing this for a custom error or us the library thiserror. I am happy to send a PR too.

@morgante
Copy link
Contributor

morgante commented Jul 9, 2024

This has been on the back of my mind for a while, so definitely happy to change and would certainly appreciate a PR to move the core library crates over to thiserror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants