Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Improve react2hooks pattern #228

Closed
morgante opened this issue Oct 25, 2023 · 1 comment
Closed

Improve react2hooks pattern #228

morgante opened this issue Oct 25, 2023 · 1 comment

Comments

@morgante
Copy link
Contributor

We currently have a pattern for converting React class components to functional components.

This pattern works nicely as a "first draft" but doesn't handle many edge cases and other scenarios. We'd like to do a spike refining it by validating and fixing some cases from open source projects.

Spec

  • Run the pattern (as is) on superset repo
  • Note the cases that don't work and incrementally add them as additional test scenarios
  • Fix the test scenarios

Guidelines

  • Please take this incrementally. It's ok to do one PR / test case at a time.
@morgante morgante assigned ghost Oct 25, 2023
@gitstart-app
Copy link
Contributor

gitstart-app bot commented Oct 25, 2023

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/grit/7330/tickets/GRIT-228

@morgante morgante closed this as completed Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant