Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] newly added icons do not load without container re-creation #1614

Closed
3 tasks done
shalak opened this issue Jun 16, 2023 · 0 comments
Closed
3 tasks done

[Bug] newly added icons do not load without container re-creation #1614

shalak opened this issue Jun 16, 2023 · 0 comments
Labels
not a bug This doesn't seem right

Comments

@shalak
Copy link
Contributor

shalak commented Jun 16, 2023

Description

When adding new icons to a directory mount, the icons are not loaded until the container is recreated

Steps to reproduce

  1. Create docker-compose with a directory mount dedicated for icons, e.g.:
  homepage:
    image: ghcr.io/benphelps/homepage:latest
    restart: unless-stopped
    volumes:
      - /path/to/config:/app/config
      - /path/to/icons:/app/public/icons
      - /path/to/wallpapers:/app/public/wallpapers
  1. Copy new icon file to icons dir, e.g. /path/to/icons/proxmox.png
  2. Add new service to /path/to/config/services.yaml, e.g.:
- CategoryName:
    - ServiceName:
        href: https://url.to.service
        icon: /icons/proxmox.png
  1. Open homepage

Expected:

Icon is loaded

Actual:

Icon is not loaded, logo placeholder is shown instead:
image

Restarting the container solves the issue.

homepage version

v0.6.20 (6046f79, May 19, 2023)

Installation method

Docker

Configuration

No response

Container Logs

No response

Browser Logs

404 on the proxmox.png appears

Troubleshooting

I docker execed into the container and confirmed that the /app/public/icons/proxmox.png exists and is readable.

Other

No response

Before submitting, I have made sure to

@shalak shalak added bug Something isn't working unconfirmed labels Jun 16, 2023
@shamoon shamoon added not a bug This doesn't seem right and removed bug Something isn't working unconfirmed labels Jun 16, 2023
@gethomepage gethomepage locked and limited conversation to collaborators Jun 16, 2023
@shamoon shamoon converted this issue into discussion #1615 Jun 16, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
not a bug This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants