Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid mounting config as data #56

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Avoid mounting config as data #56

merged 1 commit into from
Oct 9, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Sep 16, 2023

Summary

Fixes #54.

Motivation

Consistency and simplicity.

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

salim-b added a commit to salim-b/create-hyas that referenced this pull request Sep 16, 2023
@salim-b
Adapt files for thuliteio/doks-core#56
9da3e1e
This was referenced Sep 16, 2023
Merged
Closed
h-enk
h-enk approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 😸

@h-enk h-enk merged commit 1aa81b6 into thuliteio:main Oct 9, 2023
@salim-b salim-b deleted the pure-config branch October 9, 2023 13:06
h-enk added a commit to thuliteio/create-thulite that referenced this pull request Oct 9, 2023
@h-enk
Merge pull request #24 from salim-b/pure-config
fcdf261 
Adapt files for thuliteio/doks-core#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-enk h-enk h-enk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid mounting configuration (site.Params.doks) as data (site.Data.doks)
2 participants
@salim-b @h-enk