Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templated configuration does not work with globals #28

Closed
PiotrrMenclewicz opened this issue Apr 7, 2022 · 2 comments · Fixed by #30
Closed

Templated configuration does not work with globals #28

PiotrrMenclewicz opened this issue Apr 7, 2022 · 2 comments · Fixed by #30
Labels
bug Something isn't working

Comments

@PiotrrMenclewicz
Copy link

When trying to use a global parameter saved in globals.yml, the following error is returned:

ValueError: Failed to format pattern '${data_root_path}': no config value found, no default provided

After updating hooks.py and adding a variable KEDRO_VERTEXAI_DISABLE_CONFIG_HOOK=true, global parameters start to be recognized.

@em-pe em-pe changed the title Templated configuration does not work Templated configuration does not work with globals Apr 7, 2022
@em-pe em-pe added the bug Something isn't working label Apr 7, 2022
@marrrcin
Copy link
Contributor

marrrcin commented Apr 7, 2022

We're missing globals_pattern="*globals.yml", in EnvTemplatedConfigLoader.

@em-pe
Copy link
Member

em-pe commented Apr 7, 2022

Sounds like a quick fix that we can try to address this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants