-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3.0 RC 1] Multilingual routing broken #2237
Comments
This issue first occured with the changes in 13aced5. |
In my tests, I noticed that it no longer works in the subfolder |
@bastianallgeier The line that caused the error is as follows. The if condition always returns false if app run in subfolder and the language routes never load. https://github.com/getkirby/kirby/blob/release/3.3.0/src/Cms/LanguageRoutes.php#L26-L29 |
I'm not sure if it'll help solving this issue but during the 3.0 alpha we had issues with the session handling on subfolder installs: #472. This got resolved somehow. |
I think I solved it. Could you give it a try once RC2 is here later today? Feel free to reopen, if it still happens. |
Updating to 0ef8b56 doesn't solve the issue for me. All pages still return a PS: I cannot reopen the issue. |
Ok, there's another fix. It's working for @afbora. @nilshoerrmann could you try again? |
Yes, the above change fixes the issue! |
Routing on a multilingual install of 3.3.0 RC 1 is broken and all request are redirected to the error page. The install is running in a subfolder on localhost, e. g.
http://localhost:8888/example.com
. @afbora discovered on Slack that this might be the culprit.The text was updated successfully, but these errors were encountered: