Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.0 RC 1] Multilingual routing broken #2237

Closed
nilshoerrmann opened this issue Oct 22, 2019 · 8 comments
Closed

[3.3.0 RC 1] Multilingual routing broken #2237

nilshoerrmann opened this issue Oct 22, 2019 · 8 comments
Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Milestone

Comments

@nilshoerrmann
Copy link
Contributor

Routing on a multilingual install of 3.3.0 RC 1 is broken and all request are redirected to the error page. The install is running in a subfolder on localhost, e. g. http://localhost:8888/example.com. @afbora discovered on Slack that this might be the culprit.

@nilshoerrmann
Copy link
Contributor Author

This issue first occured with the changes in 13aced5.

@afbora
Copy link
Member

afbora commented Oct 22, 2019

In my tests, I noticed that it no longer works in the subfolder

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Oct 22, 2019
@bastianallgeier bastianallgeier added this to the 3.3.0 milestone Oct 22, 2019
@afbora
Copy link
Member

afbora commented Oct 22, 2019

@bastianallgeier The line that caused the error is as follows. The if condition always returns false if app run in subfolder and the language routes never load.

https://github.com/getkirby/kirby/blob/release/3.3.0/src/Cms/LanguageRoutes.php#L26-L29

@nilshoerrmann
Copy link
Contributor Author

I'm not sure if it'll help solving this issue but during the 3.0 alpha we had issues with the session handling on subfolder installs: #472. This got resolved somehow.

@bastianallgeier
Copy link
Member

I think I solved it. Could you give it a try once RC2 is here later today? Feel free to reopen, if it still happens.

@nilshoerrmann
Copy link
Contributor Author

nilshoerrmann commented Oct 23, 2019

Updating to 0ef8b56 doesn't solve the issue for me. All pages still return a 404 error 😕

PS: I cannot reopen the issue.

@bastianallgeier
Copy link
Member

Ok, there's another fix. It's working for @afbora. @nilshoerrmann could you try again?

@nilshoerrmann
Copy link
Contributor Author

Yes, the above change fixes the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Projects
None yet
Development

No branches or pull requests

4 participants