Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireTweet crashes #147

Closed
atavism opened this issue Aug 3, 2015 · 6 comments
Closed

FireTweet crashes #147

atavism opened this issue Aug 3, 2015 · 6 comments
Assignees
Labels

Comments

@atavism
Copy link

atavism commented Aug 3, 2015

Hey @uaalto, with your latest changes from #144, and building the library off of valencia, I'm seeing FireTweet crash every time I go to open it. Not seeing anything useful in the log either. Is it working for you?

@atavism
Copy link
Author

atavism commented Aug 3, 2015

This is happening when I build from the command line. Note: sometimes I'm able to open the app, but when I click on "Sign In" or "Register" it immediately crashes.

@uaalto
Copy link
Contributor

uaalto commented Aug 3, 2015

@atavism This of course didn't happen in my system (both VM and tablet). But it looks just as the insidious #114. I think there is something wrong with the code, such as a race condition, that we didn't manage to catch yet.
The gomobile changes didn't modify any functionality in the code (just made a few things private/public), so the problem is definitely not Gomobile. Could you test the Android test app to verify this, please?
I'm pretty confident that we have something wrong, or there is a very ugly bug in Go that didn't expose previously in your case but now it does.

However, if you need to develop now, you might better rollback to your version that works before we figure out.

@uaalto uaalto changed the title FireTweet crashes with latest gomobile changes FireTweet crashes (some times, some machines) Aug 3, 2015
@uaalto uaalto changed the title FireTweet crashes (some times, some machines) FireTweet crashes Aug 4, 2015
@uaalto
Copy link
Contributor

uaalto commented Aug 6, 2015

What's the status of the issue after this PR?

@atavism
Copy link
Author

atavism commented Aug 6, 2015

Looks like it was the version of Go we were using after all. That PR fixes the issue I was having,@uaalto. Thanks!

@atavism atavism closed this as completed Aug 6, 2015
@myleshorton
Copy link
Contributor

Great work guys! Out of curiosity what version of Go should we all be using for this to work? RC1 as of this writing?

@uaalto
Copy link
Contributor

uaalto commented Aug 6, 2015

That's the version that seems to solve the issue, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants