-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Conversation
2890eb7
to
242304f
Compare
I've tried running the unit test on Travis and Wercker, and neither support creating a TUN device. The problem is that they (and Circle CI) run unprivileged docker containers for security reasons, and such containers don't have access to |
086d0fc
to
701b6c1
Compare
@hwh33 I've pushed updates that address your insightful code review comments. |
Would you mind explaining why we use ops.Go to spawn goroutines? I looked at the package a bit and it looks like it's adding context to the goroutines. That context looks useful, but how is it actually used? Is it logged somewhere? Or accessible to and used by the goroutines somehow? Also thanks for the patience with all the questions on this PR haha |
golog reports the context associated with the current goroutine when it logs. The same context is also included when we report to borda. For example, here's a log seen while running Lantern:
All those key=value pairs in square brackets are the context. |
Thanks for the thorough review! |
LGTM! Thank you for the explanation of ops.Go and the use of the context. That's helpful, especially with the example. |
Thanks for the thorough review! |
No description provided.