Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: lift property in Lift type is not optional since it has been exposed in type #237

Closed
MaximeVivier opened this issue Jun 30, 2022 · 3 comments
Closed

Issue: lift property in Lift type is not optional since it has been exposed in type #237

MaximeVivier opened this issue Jun 30, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@MaximeVivier
Copy link

Description

In the Lift type, the lift property is now exposed but it is required. When it was first exposed, it introduced a breaking change for those who weren't using it.
Introduced in PR : #214

How to Reproduce

It's a typing error when using the Lift type and not specifying the lift property.

Additional Information

No response
@MaximeVivier MaximeVivier added the bug Something isn't working label Jun 30, 2022
@mnapoli
Copy link
Member

mnapoli commented Jun 30, 2022

Oh I think it was fixed in #228 but this wasn't released. Let me tag a release.

@mnapoli
Copy link
Member

mnapoli commented Jun 30, 2022

Should be good with https://github.com/getlift/lift/releases/tag/1.19.1, thanks for the report!

@mnapoli mnapoli closed this as completed Jun 30, 2022
@MaximeVivier
Copy link
Author

Thank you very much @mnapoli !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnapoli @MaximeVivier