fix(static-website): re-enable static website hosting #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fargito
force-pushed
the
feat/static-website
branch
from
70cda85
to
2d9f68c
Compare
fargito
changed the title
fargito
force-pushed
the
feat/static-website
branch
4 times, most recently
from
806b5aa
to
effcfba
Compare
fredericbarthelet
requested changes
May 9, 2022
There was a problem hiding this comment.
Thanks @fargito for the proposed implementation :) I made some suggestion that will need a bit of refactoring. Happy to discuss in more details if you want to ;)
fargito
force-pushed
the
feat/static-website
branch
from
effcfba
to
eb0cc4b
Compare
mnapoli
approved these changes
May 11, 2022
There was a problem hiding this comment.
Thanks a lot for working on this!
All good for me, I'll let @fredericbarthelet review the changes.
fredericbarthelet
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of the single page app construct introduced a breaking change in the static website construct by removing the static website hosting.
This PR re-enables static website hosting and public read access for static buckets.
I also edited the static website tests in order to make them more strict.
Fixes #192
Also see:
@adriencaccia