-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(static-website): re-enable static website hosting #202
fix(static-website): re-enable static website hosting #202
Conversation
70cda85
to
2d9f68c
Compare
806b5aa
to
effcfba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fargito for the proposed implementation :) I made some suggestion that will need a bit of refactoring. Happy to discuss in more details if you want to ;)
effcfba
to
eb0cc4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this!
All good for me, I'll let @fredericbarthelet review the changes.
The introduction of the single page app construct introduced a breaking change in the static website construct by removing the static website hosting.
This PR re-enables static website hosting and public read access for static buckets.
I also edited the static website tests in order to make them more strict.
Fixes #192
Also see:
@adriencaccia