Add single-page-app construct

[adriencaccia]

Fix #172

[mnapoli]

Thank you for opening this! I'll review this tomorrow!

Just a question because I got lost with #172: is this PR using Lambda@Edge? From a quick search it doesn't seem so.

[adriencaccia]

Just a question because I got lost with #172: is this PR using Lambda@Edge? From a quick search it doesn't seem so.

No 😃 !

I managed to make the SPA redirection work by only adding a cloudfront function triggered by the viewer request event.

[mnapoli]

Amazing!

[mnapoli]

Thanks for addressing all this so quickly!

cc @fredericbarthelet if you want to review

I'll try out the component early next week (just to be sure) but except that I'm all good here!

[fredericbarthelet]

@adriencaccia thanks for putting this PR together :)

LGTM, except a few minor comments and e5da8c9 that can then be reverted to reduce boilerplate and avoid confusion on which mechanism is in place to redirect to index (in the PR current state, it looks like both Cloudfront and S3 are in charge of the redirect)

[mnapoli]

FYI I just tested deploying the construct and 👌 perfect.

[adriencaccia]

@adriencaccia thanks for putting this PR together :)

LGTM, except a few minor comments and e5da8c9 that can then be reverted to reduce boilerplate and avoid confusion on which mechanism is in place to redirect to index (in the PR current state, it looks like both Cloudfront and S3 are in charge of the redirect)

Thanks for the review !

One problem though, reverting e5da8c9 will not be enough, we will also need to add custom OAI as stated in my comment in the corresponding issue.

So I see a tradeoff here between:

• Managing the custom OAI
• Setting the bucket in website hosting

The current solution (website hosting) is the one with less boilerplate in my opinion. What do you think ?

[fredericbarthelet]

@adriencaccia as seen together, reverting back to OAI and private bucket (removing website hosting on S3 bucket) will work as intended with your new Cloudfront function redirecting SPA path to /. This fix + enabling redirectToMainDomain on the new construct and this PR will be good to go :)

Thanks again for your contribution, let me know if @mnapoli and I can help in any way.

[mnapoli]

@adriencaccia as seen together, reverting back to OAI and private bucket (removing website hosting on S3 bucket) will work as intended with your new Cloudfront function redirecting SPA path to /. This fix + enabling redirectToMainDomain on the new construct and this PR will be good to go :)

Thanks again for your contribution, let me know if @mnapoli and I can help in any way.

+1, yes I'd say OAI has a great advantage (private bucket). If we can get these things ☝️ IMO we're good to go!

[adriencaccia]

Hey @mnapoli @fredericbarthelet !

I made all the changes we talked about!
The origin bucket is now private. The main change is that users will get a 403 when trying to access a non existing file (I am writing this here so that we are all on the same page).

The construct is working properly on my end, can you test it ?

[fredericbarthelet]

@adriencaccia LGTM :) !
Thanks for your contribution. I'll merge and release a new version of Lift right away.

[mnapoli]

🎉 thanks @adriencaccia!