Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery update #1155

Merged
merged 8 commits into from
Mar 23, 2014
Merged

Gallery update #1155

merged 8 commits into from
Mar 23, 2014

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Mar 23, 2014

Fix #1121 and #1073

@ralsina ralsina changed the title Gallery update (WIP) Gallery update Mar 23, 2014
@ralsina
Copy link
Member Author

ralsina commented Mar 23, 2014

This should have basically no visible effect except image titles will be nicer.

@Kwpolska
Copy link
Member

Looks sane. The invariance test fails at:

-<a href="tesla_tower1_lg.jpg" class="thumbnail image-reference" title="Output/galleries/demo/tesla tower1 lg">
-                <img src="tesla_tower1_lg.thumbnail.jpg" alt="Output/galleries/demo/tesla tower1 lg"></a>
+<a href="tesla_tower1_lg.jpg" class="thumbnail image-reference" title="Tesla tower1 lg">
+                <img src="tesla_tower1_lg.thumbnail.jpg" alt="Tesla tower1 lg"></a>

This looks like a desired change. If it is, just pull it and trigger an invariance rebuild (in that order; be quick or you might need to repeat the build on Travis*). If not, fix it.

* alternatively, you can switch the invariance branch to gallery_update, wait for it to build, pull, and set the invariance branch back to master. This is hacky, but unfortunately we can’t do any better.

ralsina added a commit that referenced this pull request Mar 23, 2014
@ralsina ralsina merged commit 4101f95 into master Mar 23, 2014
@ralsina ralsina deleted the gallery_update branch March 23, 2014 11:32
@ralsina
Copy link
Member Author

ralsina commented Mar 23, 2014

Thanks @Kwpolska !

@Kwpolska
Copy link
Member

The 2.7 build crashed, for obvious reasons. I’m triggering a rebuild right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Galleries have a lot of FIXMEs
2 participants