Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourse Comments integration #425

Closed
wants to merge 2 commits into from
Closed

Discourse Comments integration #425

wants to merge 2 commits into from

Conversation

Mte90
Copy link
Contributor

@Mte90 Mte90 commented May 23, 2023

Ref: getnikola/nikola#3689

So I started working but some stuff is not clear to me.

So my needs are just 2:

  • I need to check if the article has a parameter discourse_thread and get that value
  • Print in the bottom in the comment section a HTML/JS code

So right now I saw that hooks are just 6 https://getnikola.com/extending.html#toc-entry-16 and no one of them is useful for me to print in the comment section.
It would be useful to have something to access the macro comment_link_script to print what I need but I didn't find anything. I see the cactus_comment instead use template files but I am not sure if this create troubles with themes.

Instead how to read a field in the article I didn't find a plugin that do that to replicate the code.

I have some doubts if it is the case to integrate it on theme side or by plugin. Or a plugin that is not a comment system but a task generator.

PS: the code is not yet tested.

@Kwpolska
Copy link
Member

Comment systems cannot be plugins. Instead, they should be part of Nikola core (they are just templates). Please convert your changes into Mako templates and open a pull request for getnikola/nikola.

@Mte90 Mte90 closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants