This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Issue #761 Encoding issues when pulling submissions with Arabic characters in Windows #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This avoids issues on systems that don't use UTF-8 locales by default (Windows, mainly)
dcbriccetti
approved these changes
Jul 10, 2019
|
Tested with success!! @opendatakit-bot unlabel "needs testing" |
ggalmazor
deleted the
issue_761_force_utf8_encoding_while_reading_http_entities_into_xml
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #761
What has been done to verify that this works as intended?
Manually tested on a Windows 10 machine using the form attached to the issue
Manually tested on Linux to ensure that it still worked as expected on another system.
Why is this the best possible solution? Were any other approaches considered?
This is a narrow fix and I didn't consider any other approach.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It feels like it's a safe change with no risk of affecting in an unpredictable manner.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.