This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Fix #735 - Provide message when pulling non-existent form from odk dir using cmd #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odk dir using cmd
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
============================================
- Coverage 47.53% 47.52% -0.01%
Complexity 1471 1471
============================================
Files 178 178
Lines 9665 9667 +2
Branches 672 673 +1
============================================
Hits 4594 4594
- Misses 4780 4782 +2
Partials 291 291
Continue to review full report at Codecov.
|
ggalmazor
approved these changes
Aug 8, 2019
|
Tested with success! @opendatakit-bot unlabel "needs testing" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #735
What has been done to verify that this works as intended?
Manually tested it as shown in the screenshot:
Why is this the best possible solution? Were any other approaches considered?
This approach is similar to the one used in
PullFormFromAggregateclass.https://github.com/opendatakit/briefcase/blob/master/src/org/opendatakit/briefcase/operations/PullFormFromAggregate.java#L118
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This change will inform the user in case the form id they entered is invalid. Before this, briefcase gave no error message and the user was under the impression that the desired pull operation was successful.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
No