This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Issue 777 Latest Central rejects multiple simultaneous auth methods #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Central (latest) will reject requests arriving with auth tokens and session cookies. Since we don't really need cookies for anything, this is a quick fix for this issue while we decide what to do about auth in Central
|
Tested with success! @opendatakit-bot unlabel "needs testing" |
|
Hi, @dcbriccetti! Will you have some cycles this week to do this one? We would like to release v1.17 next week if possible ;) |
dcbriccetti
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #777
What has been done to verify that this works as intended?
Manually test against bleeding edge Central server at antinod.es
Why is this the best possible solution? Were any other approaches considered?
Central (latest) will reject requests arriving with auth tokens and session cookies. Since we don't really need cookies for anything, this is a quick fix for this issue while we decide what to do about auth in Central
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There's the risk of undocumented dependency on cookies by aggregate-compatible servers that we don't know about. If any of these servers rely upon cookies that were being sent, pull/push operations could fail due to this change. Testing in known servers (Ona, Kobo...) would be required to ensure we're breaking anything.
Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.