Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

improve: dedicated error for no form selected in my forms #285

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

florianm
Copy link
Contributor

A tiny PR to emit a custom error message when a user forgot to select a form to open.

image

Other errors at form open output the error to the browser console and advise the user. This might be more informative than the "something's wrong" type generic error, or it might leak sensitive information in cases I haven't thought about - in the latter case we might not want to log the error to the browser console.

@florianm florianm added this to the 0.5.0 milestone Jan 31, 2022
@florianm florianm self-assigned this Jan 31, 2022
@florianm florianm added this to In progress in Roadmap via automation Jan 31, 2022
@lognaturel
Copy link
Member

it might leak sensitive information in cases I haven't thought about

I have a hard time imagining what kind of sensitive info you might be thinking about. Like if the user's password is in an error in clear text or something?

@florianm
Copy link
Contributor Author

florianm commented Feb 2, 2022

I too have no concrete evidence of anything sensitive being leaked here. Struggling to reproduce the scenario where a form doesn't load to see what's in that error message.
Are you happy to console.log the error?

Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm not creative enough but I'm not thinking of anything sensitive that would be leaked. More likely is that the message would not be actionable. I probably would have included the error text directly in the dialog but this is fine.

Roadmap automation moved this from In progress to Reviewer approved Feb 2, 2022
@florianm florianm merged commit e871bc5 into getodk:master Feb 2, 2022
Roadmap automation moved this from Reviewer approved to Done Feb 2, 2022
@florianm florianm deleted the 189-no-form-error branch February 2, 2022 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants