Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove user roles when they are retired #222

Closed
issa-tseng opened this issue Jul 29, 2019 · 3 comments
Closed

remove user roles when they are retired #222

issa-tseng opened this issue Jul 29, 2019 · 3 comments
Labels
enhancement New feature or behavior
Milestone

Comments

@issa-tseng
Copy link
Member

with this change should come a migration which backfixes retired users by removing their roles.

@NizamLZ
Copy link
Contributor

NizamLZ commented Sep 18, 2019

I went through the code and found that, when a user is deleted(assuming retired==deleted), we are setting the deletedAt field in actors table which marks the actor linked to the user as deleted. In order to remove their roles, I was thinking that calling the actor.unassignRole() should do what we want.

By migration you mean, a new one which deletes all the role assignments of the previously deleted actors right?

@NizamLZ
Copy link
Contributor

NizamLZ commented Sep 18, 2019

@opendatakit-bot claim

@issa-tseng
Copy link
Member Author

hi! yes, the goal is to remove every role assigned to them. thanks for taking a look, soon i can cross one item off my own list. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or behavior
Projects
None yet
Development

No branches or pull requests

2 participants