bug #25: second attempt to deal with nginx boot problems. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this time we just start nginx directly if the SSL type is anything other than letsencrypt.
yanokwa
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
daemon off might look like a problem, but according to https://stackoverflow.com/a/18861312/152938, it's safe for Docker containers. Merge away!
|
yeah; in fact you have to do daemon off for docker containers because otherwise nginx starts in daemon mode, the script exits, and the docker container shuts down because its process has ended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other than letsencrypt.