Reworking Barcode widget #4032
Merged
Reworking Barcode widget #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Aug 19, 2020
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidget.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidget.java
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidget.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidget.java
Outdated
Show resolved
Hide resolved
SaumiaSinghal
force-pushed
the
barcode_widget
branch
from
3480950
to
e825946
Compare
grzesiek2010
requested changes
Aug 19, 2020
collect_app/src/main/java/org/odk/collect/android/utilities/WidgetAppearanceUtils.java
Outdated
Show resolved
Hide resolved
grzesiek2010
requested changes
Aug 20, 2020
collect_app/src/main/java/org/odk/collect/android/utilities/WidgetAppearanceUtils.java
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidget.java
Outdated
Show resolved
Hide resolved
grzesiek2010
requested changes
Aug 20, 2020
collect_app/src/test/java/org/odk/collect/android/utilities/WidgetAppearanceUtilsTest.java
Show resolved
Hide resolved
grzesiek2010
requested changes
Aug 21, 2020
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidget.java
Show resolved
Hide resolved
SaumiaSinghal
force-pushed
the
barcode_widget
branch
from
d9d728d
to
1799a15
Compare
|
Tested with success Verified on Android versions: 7.0, 8.1, 10.0 Verified cases:
|
|
Verified on Androids 5.1, 7.1 and 9. @getodk-bot unlabel "needs testing" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the work on rewriting the framework of Barcode widget.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I don't think there are any regression risks as of now. I am using an object of
CameraUtilsclass to call the non static methods, so that I can verify the behavior of the widget in scenarios when the value returned by the methods ofCameraUtilsare different.Do we need any specific form for testing your changes? If so, please attach one.
Any form having barcode widget like AllWidgetsForm
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.