Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autofill #5470

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Disable autofill #5470

merged 2 commits into from
Mar 8, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Mar 1, 2023

Closes #5469

This seems to be a bug in Android 10. It seems like we don't need autofill so it's ok to disable it and avoid the issue.

What has been done to verify that this works as intended?

I've debuged the code to make sure the code in android.view.View class that used to throw the exception is not called.

Why is this the best possible solution? Were any other approaches considered?

I was thinking about just catching the exception but this does not guarantee that the app would work well when it happens so I decided to disable autofill in the whole form entry.
This is what other users recommended too:

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This issue will be extremely difficult to reproduce so I think there is nothing to test here. The change will be tested during regression testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010
Copy link
Member Author

@lognaturel It would be good to add t to v2023.1 if possible

@seadowg seadowg merged commit 4ced146 into getodk:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeoutException: Not called in 5000ms in SoftKeyboardController.java line 28
2 participants