Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max width for form end view for wider screens #5585

Merged
merged 1 commit into from
May 15, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented May 15, 2023

Gives the warning a max width and then have all other elements constrained by it:

image

The view will still fill the screen on most phones, but this stops it expanding to fill wider screens like tablets.

What has been done to verify that this works as intended?

Verified manually.

Why is this the best possible solution? Were any other approaches considered?

I considered creating a specific layout for wider screens, but using a max width constraint feels like it will be a lot easier to maintain.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It'd be good to check the form end screen on a view different screens, but not a lot of risk here.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review May 15, 2023 10:00
@seadowg seadowg requested a review from alyblenkin May 15, 2023 10:00
Copy link
Collaborator

@alyblenkin alyblenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@grzesiek2010 grzesiek2010 merged commit 939ef20 into getodk:master May 15, 2023
@seadowg seadowg deleted the form-end-tablet branch May 16, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants