Use Title Large as base for Label Extra Large #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
changed the title
| @@ -44,7 +44,7 @@ | |||
| <item name="android:textColor">?colorPrimary</item> | |||
| </style> | |||
|
|
|||
| <style name="TextAppearanceLabelExtraLarge" parent="TextAppearance.Material3.LabelLarge"> | |||
| <style name="TextAppearance.Collect.LabelExtraLarge" parent="TextAppearance.Material3.TitleLarge"> | |||
There was a problem hiding this comment.
If now it extends TitleLarge wouldn't it be better to update the title too?
textAppearanceLabelExtraLarge -> textAppearanceTitleLarge
TextAppearance.Collect.LabelExtraLarge - > TextAppearance.Collect.TitleLarge
There was a problem hiding this comment.
We're not actually changing ?textAppearanceTitleLarge though - just using it as the base for our custom "Label Extra Large" style.
grzesiek2010
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5583
What has been done to verify that this works as intended?
Verified manually.
Why is this the best possible solution? Were any other approaches considered?
I could have just modified the font weight of the existing style, but it seemed like everyone was happier with what they'd seen with
textAppearanceTitleLargeand a modified size, so I did that instead. I think we want to keep our custom style as we're still very much introducing a repeated text style that doesn't fit in to Material 3's typographic tokens.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Not much risk here. This can be merged after a quick visual review rather than any QA.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.