Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Title Large as base for Label Extra Large #5588

Merged
merged 2 commits into from
May 17, 2023
Merged

Use Title Large as base for Label Extra Large #5588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a517aa
Use title large as base for label extra large
seadowg May 16, 2023
94a8834
Namespace custom text appearance
seadowg May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion collect_app/src/main/res/values/theme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@

<item name="textAppearanceBodyLarge">?textAppearanceBody1</item>
<item name="textAppearanceLabelLarge">@style/TextAppearance.Material3.LabelLarge</item>
<item name="textAppearanceLabelExtraLarge">@style/TextAppearanceLabelExtraLarge</item>
<item name="textAppearanceLabelExtraLarge">@style/TextAppearance.Collect.LabelExtraLarge</item>
<item name="textAppearanceTitleLarge">@style/TextAppearance.Material3.TitleLarge</item>

<item name="shapeAppearanceCornerMedium">@style/ShapeAppearance.Material3.Corner.Medium</item>
Expand Down
2 changes: 1 addition & 1 deletion collect_app/src/main/res/values/typography.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<item name="android:textColor">?colorPrimary</item>
</style>

<style name="TextAppearanceLabelExtraLarge" parent="TextAppearance.Material3.LabelLarge">
<style name="TextAppearance.Collect.LabelExtraLarge" parent="TextAppearance.Material3.TitleLarge">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If now it extends TitleLarge wouldn't it be better to update the title too?
textAppearanceLabelExtraLarge -> textAppearanceTitleLarge
TextAppearance.Collect.LabelExtraLarge - > TextAppearance.Collect.TitleLarge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not actually changing ?textAppearanceTitleLarge though - just using it as the base for our custom "Label Extra Large" style.

<item name="android:textSize">18sp</item>
</style>
</resources>