When a control in "Access control" settings is unchecked, hide that control #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
requested changes
May 16, 2023
|
|
||
| <View |
There was a problem hiding this comment.
I think you can use layout_GoneMarginX attributes instead of a spacer view here. There's an example in property.xml.
Fixed. |
seadowg
approved these changes
May 17, 2023
| <com.google.android.material.button.MaterialButton | ||
| android:id="@+id/save_as_draft" | ||
| style="@style/Widget.Material3.Button.OutlinedButton" | ||
| <androidx.constraintlayout.widget.ConstraintLayout |
There was a problem hiding this comment.
I think there must be a way to do this without nested ConstraintLayouts (maybe using Barrier), but it's really awkward to work out. Happy to go with this for now.
|
Tested With Success! Verified on device with Android 13 Verified cases:
|
|
Tested With Success! Verified on device with Android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5581
What has been done to verify that this works as intended?
I've tested the changes manually and updated automated tests.
Why is this the best possible solution? Were any other approaches considered?
As described in the issue, we decided that in order to make the behavior consistent across the app, the buttons should be hidden not disabled. When it comes to the implementation itself there is nothing important to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's a safe pr, please just verify that buttons are hidden (if disabled in settings) as described in the issue.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.