Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change button icon and label for finalized forms on form map #5598

Merged
merged 3 commits into from
May 22, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented May 18, 2023

Closes #5596

What has been done to verify that this works as intended?

I've tested the changes manually and updated the automated tests.

Why is this the best possible solution? Were any other approaches considered?

There is nothing to discuss regarding the implementation.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

As described in the issue the button should reflect the action which in the case of finalized form is viewing a form not editing it. I can't think of anything risky here.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review May 18, 2023 09:33
@grzesiek2010 grzesiek2010 requested a review from seadowg May 18, 2023 09:33
@dbemke
Copy link

dbemke commented May 22, 2023

Tested with Success!

Verified on device with Android 10

Verified cases:

@srujner
Copy link

srujner commented May 22, 2023

Tested with Success!

Verified on device with Android 13

@grzesiek2010 grzesiek2010 merged commit f4a41c2 into getodk:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change button label for finalized forms on form map
4 participants