Fix for #5634 Crash after zooming map

[dimwight]

Fixes #5634

What has been done to verify that this works as intended?

Tested manually using issue form.

Why is this the best possible solution? Were any other approaches considered?

The issue seems analogous (even identical) to #5379, with Google's CameraUpdate again choking on LatLng data. Rather than simply updating to handle the IllegalStateException thrown by this issue, I've generalised to RuntimeException.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Behaviour is now as in #5393. No impact on tests.

Do we need any specific form for testing your changes? If so, please attach one.

Form provided in #5634.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

I think I'd prefer to go with a more specific IllegalStateException catch here (as you suggest as an alternative in the PR description). RuntimeException is very broad, and might catch an unrecoverable exception that we'd actually rather have crash the app.

[dimwight]

Well yes, better safe than sorry.

[grzesiek2010]

Shouldn't we fix zooming so that it works well for points/traces/shapes instead of catching the exception? It could be a good short-term solution to avoid crashes if we wanted to have a release soon but otherwise it's not a proper solution to me. @seadowg what do you think?

[seadowg]

@grzesiek2010 great point! I think avoiding the crash is a good step forward, but agree that we probably want to add another issue for improving the zoom behaviour. That's probably a good thing to look at after @getodk/testers have had a play with this.

[dbemke]

Tested with Success!

Verified on Androids: 10

Verified cases:

• issue Crash of the app after zooming to points in a map-internal-select form with Google maps #5634 is no longer reproducible
• different sources of maps

[srujner]

Tested with Success!

Verified on Androids: 13

[dimwight]

Tested with Success!

Thanks guys 😀