Use implicit action intent for action test #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -762,7 +762,6 @@ class FormUriActivityTest { | |||
| assertStartSavedFormIntent(null, instance.dbId, true) | |||
| } | |||
|
|
|||
| // TODO: Replace the explicit FormUriActivity intent with an implicit one Intent.ACTION_EDIT once it's possible https://github.com/android/android-test/issues/496 | |||
There was a problem hiding this comment.
Why didn't you convert it to use an implicit intent too?
There was a problem hiding this comment.
Ah sorry I meant to leave a comment and totally forgot: implicit action Intents don't work in Robolectric, but that feels ok here as we're testing an Activity rather than an action. The instrumentation tests (like FormEditActionTest) check that the app responds to the action.
grzesiek2010
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with AndroidX test appears to be fixed now!