-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DB ANRs during form entry #5867
Merged
Merged
Changes from 27 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
582591a
Remove UI thread writes to the DB
seadowg 3c03dbf
Add slow call for accessing readable database
seadowg 64be103
Load BlankFormListItems off the UI thread
seadowg 70a057e
Use Flow instead of LiveData to run map on background thread
seadowg f51a815
Convert TestScheduler to Kotlin
seadowg 781c04c
Support using Scheduler for Flows
seadowg c506468
Fix Form equality for StateFlow
seadowg 3eaf6e6
Add Flow support to FakeScheduler
seadowg 16591fc
Fix test helper usage
seadowg 629e764
Rename method
seadowg b3743aa
Assert form can be started on background thread
seadowg 8a82545
Move form path to constructor
seadowg 50749f8
Use Uri as input for FormLoaderTask
seadowg 6631caf
Ignore broken tests for now
seadowg 11a0fdb
Allow loading form without StrictMode violation
seadowg 95ed0a6
Lock in current StrictMode coverage for forms db
seadowg b928e90
Lock in current StrictMode coverage for forms db
seadowg e84d3fa
Rework FormLoaderTask tests
seadowg 87b77f0
Update and reenable remaining FormLoaderTask tests
seadowg aa69ee8
Add loading state to FormUriActivity
seadowg 3ca0a73
Remove new Form and Instance fields
seadowg 859f0c4
Remove unused field
seadowg aaa54b7
Move change language logic to view model
seadowg d314f45
Remove unneeded variable
seadowg bdef028
Fix param names
seadowg eee3ec4
Correct test description
seadowg 4f74596
Simplify ExternalSecondaryInstanceTest
seadowg 8d537ae
Fix case where form has been deleted
seadowg c60752e
Simplify boolean logic
seadowg f5fd65c
Fix deleted form logic
seadowg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...formentry/DynamicPreLoadedDataPullTest.kt → ...icpreload/DynamicPreLoadedDataPullTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't work with cases where there was already a value set on the
LiveData
.