Add icons to 'Save as draft' and 'Finalize'

[grzesiek2010]

Closes #5935

Before	After

Why is this the best possible solution? Were any other approaches considered?

I've just added icons to the two buttons mentioned in the issue. @alyblenkin in https://www.figma.com/file/KFi9hIQdrRgo0rLqIC7Sg8/ODK-user-flows?type=design&node-id=4092-15997&mode=design&t=LxacBD1eYjJoYsp3-0 the first button uses black color but it's just a mockup and the color shouldn't be changed right?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Just make sure the icons look good.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[alyblenkin]

I've just added icons to the two buttons mentioned in the issue. @alyblenkin in https://www.figma.com/file/KFi9hIQdrRgo0rLqIC7Sg8/ODK-user-flows?type=design&node-id=4092-15997&mode=design&t=LxacBD1eYjJoYsp3-0 the first button uses black color but it's just a mockup and the color shouldn't be changed right?

The colour shouldn't change - I was updating the styles for something else and didn't notice that it changed there!

Could we center the icons and text, as we do with the "Back" and "Next" buttons and the "Save Form" dialog?

[grzesiek2010]

Could we center the icons and text, as we do with the "Back" and "Next" buttons and the "Save Form" dialog?

Yes, it's done.

[seadowg]

I think we do this for all Material buttons. Should we set our own ?materialButtonOutlinedIconStyle and ?materialButtonIconStyle that extend the default styles and add this do you think?

[grzesiek2010]

Not for all, first_launch_layout is one example. There are some more but in other cases, we usually use wrap_content as android:layout_width, and then that difference is not visible. @alyblenkin what do you think should we always remove that space between the icon and the text? If so please file a separate issue.

[srujner]

Tested with Success!

Verified on device with Android 13

Verified cases:

• Works toward Finalization flow: Add icons to 'Save as draft' and 'Finalize' #5935;
• Icons in the end of the form screen;
• Light and Dark mode;
• Different Button and text sizes set in the app or in the device settings;
• Different Languages;
• Rotate the screen and minimize the app.

[dbemke]

Tested with Success!

Verified on device with Android 10